https://github.com/cmatsuoka/figlet/issues/4
lorenzogatti commented on Oct 28, 2014:
Another case of buffer overrun in the same function, again for right to left
layout: smushing away more characters that are contained in the outputline[]
buffers, with STRCAT being passed an invalid pointer (past the end of an
outputline[] buffer).
How is it possible to smush more characters than the length of the buffer? A
single character can be wider than the current line, but smushamt() doesn't
limit the amount of smushing to the length of the current line. Enormous
amounts of smushing are possible with space-rich fonts, such as the Obanner
collection.
Fixed in smushamt() by limiting the range of the result.
Test case:
$ figlet -f obanner132.flf -R -x -o -p -w 77 "Banner, o Banner"
--
Original fix by Lorenzo Gatti, reworked by Claudio Matsuoka.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Local string buffer was being operated without proper initialization, causing
wcslen() to operate on invalid values.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Environment variable FIGLET_FONTDIR can be used to set the path to search
for font files. This variable is used in the test script when FIGlet is
installed on a staging directory.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Use outchr as the ouput character type (instead of char) when computing
kerning, to prevent corruption with tlf2 fonts
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Fix output corruption on line breaks caused by a previous attempt to
fix invalid memory accesses when smushing at the start of the line.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Reduce duplicate code by moving file opening code to the FIGopen()
function. This function is used to open font and control files, and
will be used to open multiple font files in ransom mode.
For code simplicity, DEFAULTFONTFILE is now defined without suffix.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Option -I5 lists supported file formats. If FIGlet is compiler with
TLF_FONTS defined, it will show tlf2 besides the always present flf2.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
If a bad font file name is specified, display only the font name
without suffix, otherwise only the .tlf suffix is displayed (if
TLF_FONTS is defined)
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Found by inspection, the absence of function prototypes cause the compiler
to not issue a warning about this problem.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
The TLF font format is used by TOIlet and is very similar to the FLF
font format, the only difference being the presence of UTF-8 encoded
Unicode characters. This patch adds TLF support to FIGlet if TLF_FONTS
is defined in Makefile.
When TLF_FONTS is defined, the internal character format is changed
to UCS-4 wide characters. System requirements are support to UTF-8
multibyte encoding, a font capable of displaying Unicode glyphs and an
implementation of C99 wchar.h.
Warning: UTF-8 characters are allowed as endmarks and sub-characters, but
not as a hardblank symbol.
Example:
$ fortune | ./figlet -fpagga
░█▀█░▀█▀░█▀█░█▀▀░▀█▀░█░█░░░█▀█░█▀▀░█▀▄░█▀▀░█▀▀░█▀█░▀█▀░░░█▀█░█▀▀
░█░█░░█░░█░█░█▀▀░░█░░░█░░░░█▀▀░█▀▀░█▀▄░█░░░█▀▀░█░█░░█░░░░█░█░█▀▀
░▀░▀░▀▀▀░▀░▀░▀▀▀░░▀░░░▀░░░░▀░░░▀▀▀░▀░▀░▀▀▀░▀▀▀░▀░▀░░▀░░░░▀▀▀░▀░░
░█▀▀░█░█░█▀▀░█▀▄░█░█░▀█▀░█░█░▀█▀░█▀█░█▀▀░░░▀█▀░█▀▀░░░█▀▀░█▀▄░█▀█░█▀█░░░
░█▀▀░▀▄▀░█▀▀░█▀▄░░█░░░█░░█▀█░░█░░█░█░█░█░░░░█░░▀▀█░░░█░░░█▀▄░█▀█░█▀▀░░░
░▀▀▀░░▀░░▀▀▀░▀░▀░░▀░░░▀░░▀░▀░▀▀▀░▀░▀░▀▀▀░░░▀▀▀░▀▀▀░░░▀▀▀░▀░▀░▀░▀░▀░░░▀░
░░░░░░░░░░░░░░░▀█▀░█░█░█▀▀░█▀█░█▀▄░█▀█░█▀▄░█▀▀
░░░░░▄▄▄░▄▄▄░░░░█░░█▀█░█▀▀░█░█░█░█░█░█░█▀▄░█▀▀
░░░░░░░░░░░░░░░░▀░░▀░▀░▀▀▀░▀▀▀░▀▀░░▀▀▀░▀░▀░▀▀▀
░█▀▀░▀█▀░█░█░█▀▄░█▀▀░█▀▀░█▀█░█▀█
░▀▀█░░█░░█░█░█▀▄░█░█░█▀▀░█░█░█░█
░▀▀▀░░▀░░▀▀▀░▀░▀░▀▀▀░▀▀▀░▀▀▀░▀░▀
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
License change was discussed in the mailing list and authors agreed
to use a non-restrictive license as the AFL mandated redistribution
of source code with each copy of the binary, and could also conflict
with the GPL license.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Updated to version 2.2.3, release date 12 January 2011, and also add self
to author list with current year in Copyright notice.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
List current changes to the CHANGES file and call this version 2.3.
The version and date must be updated in several places before the
final release, including the FAQ and all man pages.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Either initialize unitialized variables to sensible values, or supress
the warning in case the variable is always correctly initialized.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Smushing characters at the line start can cause the next character to
be copied to an offset before the start of the line buffer. In this
case, add an offset to source and copy to a valid destination position.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
By Micah Cowan: "the meanings of the SHIFT-OUT (0x0E) and SHIFT-IN
(0x0F) seem to be reversed: SHIFT-OUT is intended to invoke G0 into GL,
and SHIFT-IN to invoke G1 into GR; however, the command
$ printf 'Hell\x0Er' | figlet
appears to cause figlet to interpret the final "r" as... an "r", whereas
$ printf 'Hell\x0Fr' | figlet
causes figlet to interpret the final "r" to be interpreted as SMALL
LETTER o WITH GRAVE ACCENT. I would expect exactly the opposite results.
A quick look at iso2022() seems to verify that character code 14 is
invoking G0 to GL, rather than G1."
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
Add missing headers, remove unused variables, specify implicit types.
Ensure compatibility with ancient systems is maintained.
Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
